Mentioned how to redirect and maintain the query string #10373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
approved these changes
Sep 21, 2018
| @@ -176,6 +176,9 @@ and ``redirect()`` methods:: | |||
| // redirects to a route with parameters | |||
| return $this->redirectToRoute('blog_show', array('slug' => 'my-page')); | |||
|
|
|||
| // redirects to a route and mantains the original query string parameters | |||
| return $this->redirectToRoute('blog_show', $request->query->all()); | |||
There was a problem hiding this comment.
This change looks good! I'm just thinking, would it be worth it having the base controller support the following syntax?
return $this->redirectToRoute('blog_show', $request->query);There was a problem hiding this comment.
In my opinion it's better to not add a new way to get the query string params. Let's keep things simple and minimize the number of methods/features to learn. Thanks!
javiereguiluz
added a commit
that referenced
this pull request
Sep 21, 2018
…(javiereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- Mentioned how to redirect and maintain the query string This fixes symfony/symfony#27482. Commits ------- 71d6ab1 Mentioned how to redirect and maintain the query string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes symfony/symfony#27482.