Skip to content

Update uglifyjs.rst #10401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Update uglifyjs.rst #10401

merged 2 commits into from
Nov 28, 2018

Conversation

kcassam
Copy link
Contributor

@kcassam kcassam commented Sep 25, 2018

add quick help for common error. Source : nodejs/node-v0.x-archive#3911 (comment)

add quick help for common error. Source : nodejs/node-v0.x-archive#3911 (comment)
@javiereguiluz
Copy link
Member

@kcassam thanks for this contribution. At first I was skeptical, but I looked for and it turns out that this error is pretty common ... so it's OK to add a short note about it in Symfony Docs. Thanks!

@javiereguiluz javiereguiluz added this to the 2.8 milestone Sep 26, 2018
@xabbuh xabbuh modified the milestones: 2.8, 3.4 Nov 28, 2018
@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2018

Thank you @kcassam.

@xabbuh xabbuh merged commit 6cf4973 into symfony:3.4 Nov 28, 2018
xabbuh added a commit that referenced this pull request Nov 28, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Update uglifyjs.rst

add quick help for common error. Source : nodejs/node-v0.x-archive#3911 (comment)

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

6cf4973 Reworded the caution message
0a5d70e Update uglifyjs.rst
xabbuh added a commit that referenced this pull request Nov 28, 2018
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Nov 28, 2018
* 3.4:
  Fixed the TOC of the main Forms article
  Framework configuration > Cache pools > Fix FQCN
  [symfony#10401] fix markup
  Reworded the caution message
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Nov 28, 2018
* 4.1:
  Fixed the TOC of the main Forms article
  Framework configuration > Cache pools > Fix FQCN
  Duplicate composer require in Your First Functional Test chapter
  [symfony#10401] fix markup
  Rename UserFixture to UserFixtures
  Reworded the caution message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants