-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update debug.rst #10403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update debug.rst #10403
Conversation
Mmmh this PR is related to #10399 and my PR was already merged... But this PR also fixes another issue in the text related to the issue. |
translation/debug.rst
Outdated
@@ -143,7 +143,7 @@ for the ``fr`` locale and run the command, you will get: | |||
--------- ------------------ ---------------------- ------------------------------- | |||
State Id Message Preview (fr) Fallback Message Preview (en) | |||
--------- ------------------ ---------------------- ------------------------------- | |||
missing Symfony is great J'aime Symfony Symfony is great | |||
missing Symfony is great Symfony is great Symfony is great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State Id Message Preview (fr) Fallback Message Preview (en)
--------- ------------------ ---------------------- -------------------------------
- missing Symfony is great Symfony is great Symfony is great
+ missing Symfony is great Symfony is great Symfony is great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more clear, it looks like you need to remove 2 spaces before the second occurrence of „Symfony is great“ to match the table, or does it already work?
translation/debug.rst
Outdated
@@ -162,12 +162,12 @@ translation file in the ``fr`` locale and run the command, you will get: | |||
---------- ------------------ ---------------------- ------------------------------- | |||
State Id Message Preview (fr) Fallback Message Preview (en) | |||
---------- ------------------ ---------------------- ------------------------------- | |||
fallback Symfony is great J'aime Symfony Symfony is great | |||
fallback Symfony is great Symfony is great Symfony is great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly! That's all I've done, this messages must be the same!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is in conflict with the other merged PR.
@wish-master Would you be able to rebase and resolve the conflicts here? |
This is a correction of messages for "fr" block after described steps
7fba237
to
61f7a9b
Compare
Sorry it took us so long ... but this is finally merged (in 3.4, 4.3, 4.4 and master). |
This is a correction of messages for "fr" block after described steps (as it tested for v4.1)