Skip to content

Improve is_granted documentation #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve is_granted documentation #10461

wants to merge 2 commits into from

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Oct 9, 2018

This improves the doc for the is_granted Twig function. Under the hood, it calls AuthorizationChecker::isGranted() which accepts multiple attributes to be checked, but that's not clear. I've referred to the only other part of the doc where this is clear.

@OskarStark
Copy link
Contributor

Please check your code blocks in the PR header. Thank you

@Jean85
Copy link
Contributor Author

Jean85 commented Oct 12, 2018

Thanks @OskarStark, fixed. Did you review the PR itself?

javiereguiluz added a commit that referenced this pull request Oct 12, 2018
This PR was squashed before being merged into the 2.8 branch (closes #10461).

Discussion
----------

Improve is_granted documentation

This improves the doc for the 'is_granted` Twig function. Under the hood, it calls `AuthorizationChecker::isGranted()` which accepts multiple attributes to be checked, but that's not clear. I've referred to the only other part of the doc where this is clear.

Commits
-------

8ba3229 Improve is_granted documentation
@javiereguiluz
Copy link
Member

@Jean85 thanks for this contribution. Merged!

@Jean85 Jean85 deleted the patch-2 branch October 12, 2018 16:06
an object can be pasted to be used by the voter. More information can be
found in :ref:`security-template`.
Returns ``true`` if the current user has the required role, if only one
is passed; if more than one is passed, with an array, the behavior depends
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this behaviour could be configured.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the strategy you're using:

  • affirmative (default) grants access as soon as there is one voter granting access;
  • consensus grants access if there are more voters granting access than there are denying;
  • unanimous only grants access if none of the voters has denied access;

See https://symfony.com/doc/current/components/security/authorization.html#access-decision-manager

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The access decision strategy defines how the result looks like when multiple voters voted on a certain attribute. It does not affect the internal behaviour of the RoleVoter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #10580

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umh you're right, I've mistakenly confused the two things. Thanks for spotting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants