Update to micro_kernel_trait.rst #10480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever you make a change to the "autoload' section of the composer.json file (amongst others), you need to regenerate the autoload files using composer dumpautoload, otherwise your changes will not be seen. More info : https://getcomposer.org/doc/03-cli.md#dump-autoload-dumpautoload- Sorry if the proposed changes are not marked up properly, haven't gotten the hang of Markup language just yet :)
|
Ping @Alienpruts could you apply the change suggested by @alexislefebvre? |
Co-Authored-By: Alienpruts <vandecasteele@evilones.be>
|
Sorry, this seems to have slipped by my mailbox. Done |
xabbuh
reviewed
Nov 15, 2018
kunicmarko20
approved these changes
Nov 15, 2018
ndench
approved these changes
Nov 15, 2018
xabbuh
added a commit
that referenced
this pull request
Nov 30, 2018
…bvre) This PR was merged into the 3.4 branch. Discussion ---------- Update to micro_kernel_trait.rst Whenever you make a change to the "autoload' section of the composer.json file (amongst others), you need to regenerate the autoload files using composer dumpautoload, otherwise your changes will not be seen. More info : https://getcomposer.org/doc/03-cli.md#dump-autoload-dumpautoload- Sorry if the proposed changes are not marked up properly, haven't gotten the hang of Markup language just yet :) <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- cca8833 Update micro_kernel_trait.rst fe2efd4 Update configuration/micro_kernel_trait.rst aaa2b2b Update to micro_kernel_trait.rst
xabbuh
added a commit
that referenced
this pull request
Nov 30, 2018
|
Thank @Alienpruts and @alexislefebvre for these nice changes. FYI I have reused your wording from #10481 in 9827fea. |
xabbuh
added a commit
that referenced
this pull request
Nov 30, 2018
* 3.4: Teach the user to write the command lazy loading [#10480] reuse wording from multi kernel article Update Multiple_kernels.rst Update usage.rst add annotation block to routing conditions Fix example for collection form type Update micro_kernel_trait.rst Update configuration/micro_kernel_trait.rst Update to micro_kernel_trait.rst
xabbuh
added a commit
that referenced
this pull request
Nov 30, 2018
* 4.1: Teach the user to write the command lazy loading [#10480] reuse wording from multi kernel article Update Multiple_kernels.rst Update usage.rst add annotation block to routing conditions fix the markup Clarifying what happens with --env=prod + APP_ENV=prod Fix example for collection form type Update micro_kernel_trait.rst Update configuration/micro_kernel_trait.rst Update to micro_kernel_trait.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you make a change to the "autoload' section of the composer.json file (amongst others), you need to regenerate the autoload files using composer dumpautoload, otherwise your changes will not be seen.
More info :
https://getcomposer.org/doc/03-cli.md#dump-autoload-dumpautoload-
Sorry if the proposed changes are not marked up properly, haven't gotten the hang of Markup language just yet :)