Revert a change related to flash messages and sessions #10590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz Did you mean another issue from the Symfony repository? I don't think the linked issue is related. |
|
You are right! I've updated the comment. Thanks! |
xabbuh
approved these changes
Oct 27, 2018
javiereguiluz
added a commit
that referenced
this pull request
Oct 29, 2018
…javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Revert a change related to flash messages and sessions This was done a few days ago (e6ce2f4) but there's an ongoing discussion about it in Symfony (symfony/symfony#28804) and some people are complaining on slack about the changed code. So let's revert for now to the original code. Commits ------- f96118b Revert a change related to flash messages and sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done a few days ago (e6ce2f4) but there's an ongoing discussion about it in Symfony (symfony/symfony#28804) and some people are complaining on slack about the changed code. So let's revert for now to the original code.