Skip to content

Rename content_type header to content-type #10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename content_type header to content-type #10651

wants to merge 1 commit into from

Conversation

ottaviano
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we should do this.

I'm not entirely sure about adding the comment about underscored HTTP headers. @xabbuh do you think we should add it ... or better remove it to lower our readers' cognitive load? Thanks!

kunicmarko20
kunicmarko20 reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment is not needed, it could confuse people.

@ottaviano
Copy link
Contributor Author

agree, will remove it

@ottaviano ottaviano force-pushed the fix-http-header-key branch from d49a33f to cea94f4 Compare November 9, 2018 14:49
@xabbuh xabbuh added this to the 2.8 milestone Nov 10, 2018
@xabbuh
Copy link
Member

xabbuh commented Nov 10, 2018

Thank you @ottaviano.

xabbuh added a commit that referenced this pull request Nov 10, 2018
@xabbuh
minor #10651 Rename content_type header to content-type (ottaviano)
4310a38 
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #10651).

Discussion
----------

Rename content_type header to content-type

Commits
-------

9feaac0 Rename content_type header to content-type
@xabbuh xabbuh closed this Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@ottaviano @xabbuh @javiereguiluz @kunicmarko20 @carsonbot