Recommend registering the error handler in prod #10668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what currently happens when using Symfony in a standard way, and people have been wondering online about alarming exceptions from the Debug component in production. See https://stackoverflow.com/questions/37431935/is-it-normal-to-have-symfony-component-debug-exception-fatalerrorexception-excep
|
@ogizanagi @ro0NL please review |
ro0NL
reviewed
Nov 13, 2018
| @@ -56,6 +57,12 @@ fatal errors):: | |||
|
|
|||
| ErrorHandler::register(); | |||
|
|
|||
| .. note:: | |||
|
|
|||
| This one is fine to use in a production environment and will be | |||
There was a problem hiding this comment.
not sure we should advise ppl to register as above in prod, FWBundle explicitly does ErrorHandler::register(null, false)->throwAt(-1, true);
There was a problem hiding this comment.
The first argument is null by default, as for the second, it tells the error handler to replace the previous one, which people probably want to do if they decide to use ours, right?
ogizanagi
approved these changes
Nov 13, 2018
javiereguiluz
added a commit
that referenced
this pull request
Jan 17, 2019
This PR was submitted for the 2.8 branch but it was merged into the 3.4 branch instead (closes #10668). Discussion ---------- Recommend registering the error handler in prod This is what currently happens when using Symfony in a standard way, and people have been wondering online about alarming exceptions from the Debug component in production. See https://stackoverflow.com/questions/37431935/is-it-normal-to-have-symfony-component-debug-exception-fatalerrorexception-excep Commits ------- f0cd0bf Recommend registering the error handler in prod
|
Thanks Grégoire! We finally merged this (in 3.4). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what currently happens when using Symfony in a standard way, and
people have been wondering online about alarming exceptions from the
Debug component in production.
See https://stackoverflow.com/questions/37431935/is-it-normal-to-have-symfony-component-debug-exception-fatalerrorexception-excep