Improved the example about Choice constraint callback #10679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it works only if they are in the same namespace? |
| @@ -222,7 +222,7 @@ you can pass the class name and the method as an array. | |||
| class Author | |||
| { | |||
| /** | |||
| * @Assert\Choice(callback={"Util", "getGenres"}) | |||
| * @Assert\Choice(callback={"AppBundle\Entity\Genre", "getGenres"}) | |||
There was a problem hiding this comment.
This can also be Genre::class but I guess it is more clear this way
kunicmarko20
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
https://3v4l.org/gY4gN even if it is in the same namespace it still returns false, this seems like a valid change.
|
Marko, thanks a lot for reviewing this and for creating the sample code! |
javiereguiluz
added a commit
that referenced
this pull request
Nov 16, 2018
…aviereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- Improved the example about Choice constraint callback I don't know if this is 100% correct, but in a real Symfony project, the `callback` without the FQCN didn't work (at least when using the PHP annotations). Commits ------- dece243 Improved the example about Choice constraint callback
|
👍 |
|
I think someone took |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is 100% correct, but in a real Symfony project, the
callbackwithout the FQCN didn't work (at least when using the PHP annotations).