Skip to content

Less code #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Less code #10698

wants to merge 1 commit into from

Conversation

mel1289
Copy link
Contributor

@mel1289 mel1289 commented Nov 23, 2018

No description provided.

@kunicmarko20
Copy link
Contributor

Hi @MohamedElKadaoui, thank you for your help and congrats on your first contributions, but why did you open 2 same Pull Requests?

@mel1289
Copy link
Contributor Author

mel1289 commented Nov 23, 2018

Hi @kunicmarko20, it's a bad handling sorry

@javiereguiluz javiereguiluz added this to the 2.8 milestone Nov 27, 2018
@javiereguiluz
Copy link
Member

Much better! Thanks for improving this Mohamed.

javiereguiluz added a commit that referenced this pull request Nov 27, 2018
@javiereguiluz
minor #10698 Less code (MohamedElKadaoui)
d72818d 
This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes #10698).

Discussion
----------

Less code

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

8e6b9f6 Less code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunicmarko20 kunicmarko20 kunicmarko20 approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@mel1289 @kunicmarko20 @javiereguiluz @carsonbot