Documentation workflow context apply #10751
Conversation
3fa0a6e to
e3fd641
Compare
e3fd641 to
9dfef16
Compare
|
@lyrixx review addressed |
|
hi @lyrixx I do not know if the comment like that is ok (it is a bit weird), wdyt? Also, do you have a date for the merge of the related feature ? :) Thank you! |
|
@noniagriconomie I'd like to merge your pull request, but I'm seeing lots of conflicts when doing that. Could you please rebase this to the latest changes of the master branch? Thanks! |
|
@javiereguiluz of course i will do this asap |
2a92988 to
55fc4b8
Compare
|
@javiereguiluz Done Just i am not sure about the "versionadded:: 4.1" part when i rebased thank you |
f169ba8 to
8a7f7c5
Compare
|
@OskarStark (@HeahDude) reviews addressed, thank you! |
|
@xabbuh can we merge this one ? |
8a7f7c5 to
af0da29
Compare
|
Thank you @noniagriconomie and congratulations on your first contribution to the Symfony documentation. I have merged your PR (I have squased the commits while merging that's why the PR is shown as closed instead of merged) and made some small tweaks in e1e4efc. |
| // ... | ||
| } | ||
|
|
||
| Symfony also creates automatically for you a service for each workflow (:class:`Symfony\\Component\\Workflow\\Workflow`) or state machine (:class:`Symfony\\Component\\Workflow\\StateMachine`) you have defined in your configuration. |
There was a problem hiding this comment.
I would reword it:
Symfony creates a service for you automatically....
| // See all the available transitions for the post in the current state | ||
| $transitions = $workflow->getEnabledTransitions($post); | ||
| } | ||
| } | ||
|
|
||
| .. versionadded:: 4.1 | ||
|
|
||
| The :class:`Symfony\\Component\\Workflow\\Exception\\TransitionException` |
There was a problem hiding this comment.
Do we Need this versionadded ?
@symfony/team-symfony-docs
|
|
||
| .. versionadded:: 4.1 | ||
|
|
||
| The :method:`Symfony\\Component\\Workflow\\Registry::all` method was |
There was a problem hiding this comment.
Do we Need this versionadded ?
@symfony/team-symfony-docs
Hi,
While attending to the #SymfonyConHackday2018
I wanted to test @lyrixx implementation (symfony/symfony#29146) of a request of mine (symfony/symfony#27925) on one of my projects.
I also wanted to add/improve the documentation in the same time.
This PR is WIP as the feature is not merged yet (on its way)
thank you