Added php opening tag to sample controller #11151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me a while to figure out why the sample didn't seem to work, despite being experimented in php ; i checked many times namespace, uses and class declaration before finding that i just missed the opening tag. Think it would help others (even more if unexperimented) discovering symfony by copy/pasting sample code from the doc !
OskarStark
reviewed
Mar 14, 2019
|
Hi,
I perfectly understand that ; my feeling is that there should be a way to
avoid this pitfall.
It would be a pitty to discourage users for such a basic error (that i
made, being an experimented developper), just because copy/paste of the
first sample doesn't work immediately...
Since this is the first hand-created file in the tutorial, i though of this
addition in first place, but i agree that this may not be the right
solution to keep the documentation coherent.
Maybe there could be a warning before, or as an alternative, the user may
be directed to file generation (php bin/console make:controller
LuckyController) ?
At last, the "real" problem may not be in the documentation : the error
message i got in the console tells me the file was found but not the
controller class inside ; i though of errors in namespaces, uses, class
declaration, missing brackets, ...
Maybe the message could tell something like "or this file is not a valid
php file" ?
Hope that could help.
Regards
Le jeu. 14 mars 2019 à 08:12, Oskar Stark <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
Thank you for your contribution. I am against 👎 this change, because on
no other place, except if php and html is mixed, we added an php open tag
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11151 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdOT-_oPF5CEab6NrWtiVxRMhRkamYHks5vWfZVgaJpZM4bv3oP>
.
|
javiereguiluz
added a commit
that referenced
this pull request
Mar 14, 2019
This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #11151). Discussion ---------- Added php opening tag to sample controller It took me a while to figure out why the sample didn't seem to work, despite being experimented in php ; i checked many times namespace, uses and class declaration before finding that i just missed the opening tag. Think it would help others (even more if unexperimented) discovering symfony by copy/pasting sample code from the doc ! <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 4c3a0d0 Added php opening tag to sample controller
|
@OskarStark you are right and we never add the In the past we received lots of complaints about this and refused to do the change. But one day we decided it's better if we listen to newcomers about this article. We added this @Krap thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out why the sample didn't seem to work, despite being experimented in php ; i checked many times namespace, uses and class declaration before finding that i just missed the opening tag. Think it would help others (even more if unexperimented) discovering symfony by copy/pasting sample code from the doc !