Skip to content

Create a migration guide in the docs. #11330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Create a migration guide in the docs. #11330

merged 1 commit into from
Jun 8, 2019

Conversation

dbrumann
Copy link
Contributor

@dbrumann dbrumann commented Apr 7, 2019

The general idea is to provide advice on how to migrate
an existing application over to Symfony using some
proven approaches.

The page should provide around 3 alternatives and some
discussion when they might be suitable as well as
additional resources like videos on this topics from
the official Symfony YouTube-channel.

@dbrumann
Copy link
Contributor Author

dbrumann commented Apr 7, 2019

@mpdude and @derrabus feel free to add commits to this PR

@wouterj wouterj added the ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
@mpdude
Copy link
Contributor

mpdude commented Apr 7, 2019

Just for the record, I've talked about this at the Symfony User Group Cologne back in 2013. Unfortunately, slides are in German and of limited use without the sound track:

https://www.slideshare.net/webfactory/marry-me-public

Additionally, we've published the https://github.com/webfactory/WebfactoryLegacyIntegrationBundle back then and since used it successfully on several legacy systems.

@derrabus
Copy link
Member

derrabus commented Apr 7, 2019

My talk is from 2016 which in itself is somewhat legacy now. ;-)

@wouterj
Copy link
Member

wouterj commented Apr 7, 2019

@weaverryan @javiereguiluz I'm also interested to know your opinion about this article. We shortly discussed this at EU-FOSSA and came up with this idea to explain some general ideas on how to migrate from legacy code to Symfony in the documentation.

As it's all very specific to the project, we can't document one approach that works for all. But showing some approaches (from the least to most radical) can imo be a nice addition for projects facing this problem.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far Denis

@dbrumann dbrumann changed the title [WIP] Create a migration guide in the docs. Create a migration guide in the docs. Apr 28, 2019
@dbrumann dbrumann marked this pull request as ready for review April 28, 2019 11:23
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbrumann thanks for working on this! I think this is ready to merge. Do you agree?

@dbrumann
Copy link
Contributor Author

dbrumann commented May 3, 2019

Thanks for your feedback @javiereguiluz and everyone else :)
I am happy with the current state and think this is ready to be merged.

@derrabus
Copy link
Member

derrabus commented May 3, 2019

@dbrumann I'd like to do another review on the weekend, if that's okay for you.

@dbrumann
Copy link
Contributor Author

dbrumann commented Jun 7, 2019

What do you say, is this ready to be merged? @OskarStark, @javiereguiluz

@OskarStark
Copy link
Contributor

Yes but this should go into 4.2 instead of master IMHO

The general idea is to provide advice on how to migrate
an existing application over to Symfony using some
proven approaches.

The page should provide around 3 alternatives and some
discussion when they might be suitable as well as
additional resources like videos on this topics from
the official Symfony YouTube-channel.
@dbrumann dbrumann changed the base branch from master to 4.2 June 8, 2019 10:51
@dbrumann
Copy link
Contributor Author

dbrumann commented Jun 8, 2019

I rebased and changed the target branch to 4.2

@wouterj wouterj self-assigned this Jun 8, 2019
@wouterj wouterj merged commit b91249f into symfony:4.2 Jun 8, 2019
wouterj added a commit that referenced this pull request Jun 8, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

Create a migration guide in the docs.

The general idea is to provide advice on how to migrate
an existing application over to Symfony using some
proven approaches.

The page should provide around 3 alternatives and some
discussion when they might be suitable as well as
additional resources like videos on this topics from
the official Symfony YouTube-channel.

Commits
-------

b91249f Creates a migration guide.
wouterj added a commit that referenced this pull request Jun 8, 2019
* 4.2:
  [#11330] Restructured the Migration guide a bit while proof-reading
  Creates a migration guide.
wouterj added a commit that referenced this pull request Jun 8, 2019
* 4.3:
  [#11330] Restructured the Migration guide a bit while proof-reading
  Creates a migration guide.
wouterj added a commit that referenced this pull request Jun 8, 2019
* 4.4:
  [#11330] Restructured the Migration guide a bit while proof-reading
  Creates a migration guide.
@wouterj
Copy link
Member

wouterj commented Jun 8, 2019

Hi @dbrumann! Thanks a lot of the huge effort put into this PR!!

As I wasn't able to review your PR anywhere soon after you created it, I've merged it directly and did a proof-read and changes afterwards. You can see all these changes in db82d54. It's mostly structuring the "Prerequisites" section a bit and some minor clearifications/breaking long sentences/paragraphs.

Again thanks and also thanks to @derrabus for closely reviewing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants