Update serializer.rst #11384

Raulnet · 2019-04-09T13:51:33Z

shows the new way to define a circular_reference_handler on the normalizer
symfony/symfony#30998

shows the new way to define a `circular_reference_handler` on the nromalizer

wouterj

Looks great! Thanks for taking the time to fix the documentation!

wouterj · 2019-04-09T14:03:26Z

components/serializer.rst

+            AbstractNormalizer::CIRCULAR_REFERENCE_HANDLER => function ($object, $format, $context) {
+                return $object->getName();
+            }
+        ];


Little note: we should fix indentation here (the array contents should be indented with only 4 spaces and ]; should be on the same column as $defaultContext =). But we can do that while merging your PR.

Yes, we'll make these minor changes while merging.

javiereguiluz · 2019-04-09T14:18:37Z

Thanks for this fix and congrats on your first Symfony Docs contribution!

This PR was merged into the 4.2 branch. Discussion ---------- Update serializer.rst shows the new way to define a `circular_reference_handler` on the normalizer symfony/symfony#30998 Commits ------- d562333 Update serializer.rst

Update serializer.rst

d562333

shows the new way to define a `circular_reference_handler` on the nromalizer

carsonbot added the Status: Needs Review label Apr 9, 2019

wouterj approved these changes Apr 9, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Apr 9, 2019

javiereguiluz added this to the 4.2 milestone Apr 9, 2019

javiereguiluz merged commit d562333 into symfony:4.2 Apr 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update serializer.rst #11384

Update serializer.rst #11384

Raulnet commented Apr 9, 2019

wouterj left a comment

wouterj Apr 9, 2019

javiereguiluz Apr 9, 2019

javiereguiluz commented Apr 9, 2019

Update serializer.rst #11384

Update serializer.rst #11384

Conversation

Raulnet commented Apr 9, 2019

wouterj left a comment

Choose a reason for hiding this comment

wouterj Apr 9, 2019

Choose a reason for hiding this comment

javiereguiluz Apr 9, 2019

Choose a reason for hiding this comment

javiereguiluz commented Apr 9, 2019