edit normalizer deprecated method on 4.2 #11394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Apr 10, 2019
wouterj
added a commit
that referenced
this pull request
Jun 1, 2019
This PR was merged into the 4.2 branch. Discussion ---------- edit normalizer deprecated method on 4.2 i have added documentation for deprecated method in Normalizer `Symfony\Component\Serializer\Normalizer\AbstractNormalizer::setCallbacks` `Symfony\Component\Serializer\Normalizer\AbstractNormalizer::setCircularReferenceLimit` `Symfony\Component\Serializer\Normalizer\AbstractNormalizer::setMaxDepthHandler` And edit the code for the new params declaration; And move the text `..deprecated 4.2 ...` below the demo code for more consistency Commits ------- f02e6fd edit normalizer deprecated method on 4.2
|
Thanks @Raulnet for this PR! I'm sorry it took soo long before we merged this one, we still greatly appreciate it :). Meanwhile, some other PRs already fixed some cases fixed by this PR. However, the max depth was not yet covered and I liked some of the other improvements you made (with the circular reference depth). So I've carefully merged those changes into the docs. Thanks again! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have added documentation for deprecated method in Normalizer
Symfony\Component\Serializer\Normalizer\AbstractNormalizer::setCallbacksSymfony\Component\Serializer\Normalizer\AbstractNormalizer::setCircularReferenceLimitSymfony\Component\Serializer\Normalizer\AbstractNormalizer::setMaxDepthHandlerAnd edit the code for the new params declaration;
And move the text
..deprecated 4.2 ...below the demo code for more consistency