[Translation] TransChoice invalide plural translation #11425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs update after code review ping @Simperfit |
|
Status: Needs Work |
OskarStark
reviewed
Apr 15, 2019
| @@ -230,11 +230,18 @@ method or the ``transchoice`` tag/filter in your :ref:`template <translation-tag | |||
| For much more information, see :ref:`component-translation-pluralization` | |||
| in the Translation component documentation. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This blank line should be removed
| .. deprecated:: 4.2 | ||
|
|
||
| In Symfony 4.2 the ``Translator::transChoice()`` method was deprecated in | ||
| favor of using ``Translator::trans()`` with ``%count%`` as the parameter | ||
| driving plurals. | ||
|
|
||
|
|
There was a problem hiding this comment.
This blank line should be removed
|
This PR is outdated in view of the latest update 😉 |
|
Closing here as the related PR has been closed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is linked to the new feature at symfony/symfony#31110