Update Length constraint description (mb_strlen) #11456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Apr 23, 2019
…amxavier) This PR was merged into the 3.4 branch. Discussion ---------- Update Length constraint description (mb_strlen) The current implementation ([3.4] and [4.2]) uses only `mb_strlen` (after `mb_check_encoding`). [3.4]: https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Validator/Constraints/LengthValidator.php#L42-L44 [4.2]: https://github.com/symfony/symfony/blob/4.2/src/Symfony/Component/Validator/Constraints/LengthValidator.php#L43-L45 History: [years ago][1] the `grapheme_strlen` attempt was replaced with `iconv_strlen` (and `preg_replace`), [later on][2] the whole implementation (including plain `strlen`) was reduced to keep only `iconv_strlen`, and [finally][3] (but still years ago) `iconv_strlen` was replaced with `mb_check_encoding` + `mb_strlen`. [1]: symfony/symfony@915fcd8 [2]: symfony/symfony@303f05b#diff-467932f4ce8a7100a8e0184cf9463e6a [3]: symfony/symfony@27f5f81#diff-467932f4ce8a7100a8e0184cf9463e6a Commits ------- 03bd47f Update Length constraint description (mb_strlen)
|
@guilliamxavier nice fix and fantastic explanation! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation (3.4 and 4.2) uses only
mb_strlen(aftermb_check_encoding).History: years ago the
grapheme_strlenattempt was replaced withiconv_strlen(andpreg_replace), later on the whole implementation (including plainstrlen) was reduced to keep onlyiconv_strlen, and finally (but still years ago)iconv_strlenwas replaced withmb_check_encoding+mb_strlen.