Recommend including the package name in messages #11522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version numbers, but they make more sense when you know the package name. Most times, you will be able to figure it out from some FQCN, but this should make things easier for everyone.
nicolas-grekas
approved these changes
May 4, 2019
OskarStark
approved these changes
May 4, 2019
javiereguiluz
added a commit
that referenced
this pull request
May 6, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Recommend including the package name in messages Version numbers, but they make more sense when you know the package name. Most times, you will be able to figure it out from some FQCN, but this should make things easier for everyone. cc @nicolas-grekas who told me about this best practice I'm unsure about whether this is the best branch for that kind of (pedantic ?) change Commits ------- d2cfba7 Recommend including the package name in messages
|
Grégoire, thanks for improving this! While merging I replaced |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version numbers, but they make more sense when you know the package
name. Most times, you will be able to figure it out from some FQCN, but
this should make things easier for everyone.
cc @nicolas-grekas who told me about this best practice
I'm unsure about whether this is the best branch for that kind of (pedantic ?) change