-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[HttpFoundation] Add documentation about the session. #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Native PHP Save Handlers | ||
~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
So-called 'native' handlers are session handlers are either compiled into PHP or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mising that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary here since this is a direct statement of what native handlers are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So-called 'native' handlers are session handlers are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@stof - thanks for the great feedback. This should be good to go now. |
|
||
Example of use: | ||
|
||
use Symfony\\Component\\HttpFoundation\\Session\\Session; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing either ::
at the end of the previous paragraph or .. code-block:: php
to make it a code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
All corrections have been made, thanks! |
This is ready for merge - I may expand the documentation in a second PR later, but for now this is a start :-) |
@weaverryan @fabpot is there anything pending for this PR to be merged? |
Hey Drak! I'll take a look at this today and merge it in. Thanks! |
[HttpFoundation] Add documentation about the session.
Really really nice Drak! This is probably the most thoroughly-documented component section we have yet. I made some minor tweaks in sha: 679374b Thanks! |
We need to find someone who can document the Security component. I am not familiar enough with it. |
Haha, yes we do - I think that component will likely be several pieces instead of just one document. I know enough about it, just a matter of finding the time. |
Refs symfony/symfony#3493 and will close #1135