Update installation.rst #11596
Update installation.rst #11596
Conversation
update encore package name, `encore` is not recognized by composer currently
|
Hmm, but it should, according to the aliases named here: encore, webpack and webpack-encore //cc @weaverryan |
|
🤔 so this should be bug submitted somewhere else? if this is the case, @OskarStark can you please create a bug in the correct place and add a link to it in this thread. thank you in advance. |
|
Symfony uses Once you install it, you can use "package aliases" to install stuff. However, to not confuse people not using Flex (like I assume the project you're working on), I think we decided not to use aliases in the documentation. So 👍 on this change! |
|
I agree with being more clear here 👍🏻 |
|
I'm afraid I disagree here. I think that installing the bundle it's not equivalent to running the recipe, because several files and dirs are created too by the recipe. Also, I don't think the current doc is confusing. It shows two different ways of installing this and the first one continuously mentions "Symfony Flex" and gives you some hints when you are not using that. This is how the doc is designed:
|
|
The thing is this IS Symfony 3.4 application (so I'm reading correct doc page I guess), except it is not using flex. |
|
Ref: #9693 |
There was a problem hiding this comment.
If we’re avoiding aliases in general in the docs, then it’s a clear +1. However, it doesn’t address the issue of if a person in a non Flex app follows these instructions - the rest of the steps would be broken. In some ways, relying on the alias guarantees that you’ll get the recipe or it won’t work at all. But for now, I guess let’s go with no aliases and try to make language clear around the fact that we expect this to also execute a Flex recipe
This PR was merged into the 3.4 branch. Discussion ---------- Update installation.rst update encore package name, `encore` is not recognized by composer currently <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 4d82f66 Update installation.rst
|
I've merged this (and made some minor rewords in bc3107b). I was wrong before. I've tested running both Composer commands and the results are the same, so let's remove the alias here. Thanks! |
update encore package name,
encoreis not recognized by composer currently