[Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entry #11597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
May 24, 2019
| @@ -1,7 +1,7 @@ | |||
| .. index:: | |||
| single: Messenger; Record messages; Transaction messages | |||
|
|
|||
| Transactional Messages: Handle Events After CommandHandler is Done | |||
| Transactional Messages: Handle New Messages After Handling is Done | |||
There was a problem hiding this comment.
It's a bit tricky: in Messenger, messages are called messages. If you're using Messenger as an event bus, you can of course call them events. I'm mostly using the word "message" to keep consistent with messenger (and not confuse with the EventDispatcher), though I keep "event" wording in the code examples.
| ], | ||
| ], | ||
| ]); | ||
|
|
There was a problem hiding this comment.
This code block didn't seem relevant anymore. I think it originally came from when dispatch_after_current_bus was not going to be included as a default middleware, so you needed to show how it was added to config.
OskarStark
reviewed
May 24, 2019
| .. note:: | ||
|
|
||
| If ``WhenUserRegisteredThenSendWelcomeEmail`` throws an exception, that exception | ||
| will be wrapped into a ``DelayedMessageHandlingException``. Using ``DelayedMessageHandlingException::getExceptions`` | ||
| will give you all exceptions that are thrown while handing a message with the ``DispatchAfterCurrentBusStamp``. | ||
|
|
||
| The ``dispatch_after_current_bus`` middleware is enabled by default. If you're |
|
Thanks Ryan. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
May 28, 2019
…dleware entry (weaverryan) This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entry Just some proofreading changes for symfony#10015! Commits ------- 599d10b minor reorg of new DispatchAfterCurrentBusMiddleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some proofreading changes for #10015!