Remove $context argument from supportsNormalization in example #11613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
May 28, 2019
|
Thanks for fixing this bug Paweł and congrats on your first Symfony Docs contribution. |
OskarStark
added a commit
that referenced
this pull request
May 28, 2019
…mple (pskt) This PR was merged into the 3.4 branch. Discussion ---------- Remove $context argument from supportsNormalization in example This PR removes `$context` argument from supportsNormalization() method. `NormalizerInterface` defines only `$data` and `$format` arguments (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Serializer/Normalizer/NormalizerInterface.php#L51) Commits ------- cd1fa25 Remove $context argument from example code
javiereguiluz
added a commit
that referenced
this pull request
Jul 19, 2019
This PR was merged into the 3.4 branch. Discussion ---------- add $context argument to supportsNormalization() reverts #11613, the context will actually be passed as the third argument here (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Serializer/Serializer.php#L242) Commits ------- 9a44b3f add $context argument to supportsNormalization()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
$contextargument from supportsNormalization() method.NormalizerInterfacedefines only$dataand$formatarguments (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Serializer/Normalizer/NormalizerInterface.php#L51)