Skip to content

Clarifying that you can't override real env vars #11669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

Clarifying that you can't override real env vars #11669

merged 1 commit into from
Jun 5, 2019

Conversation

weaverryan
Copy link
Member

As pointed out by Nicolas Grekas.

@javiereguiluz
Copy link
Member

Thanks! What about #10793? Is it still relevant?

@weaverryan
Copy link
Member Author

Omg, I forgot about that one!

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jun 5, 2019
@javiereguiluz
Copy link
Member

Thanks Ryan.

@javiereguiluz javiereguiluz merged commit eecb1c1 into symfony:4.2 Jun 5, 2019
javiereguiluz added a commit that referenced this pull request Jun 5, 2019
@javiereguiluz
minor #11669 Clarifying that you can't override real env vars (weaver…
209c3fc 
…ryan)

This PR was merged into the 4.2 branch.

Discussion
----------

Clarifying that you can't override real env vars

As pointed out by Nicolas Grekas.

Commits
-------

eecb1c1 Clarifying that you can't override real env vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverryan @javiereguiluz @carsonbot