Revamped the main configuration file #11690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
requested changes
Jun 8, 2019
| #. Add the needed configuration files in ``config/packages/staging/`` to | ||
| define the behavior of the new environment. Symfony loads first the files in | ||
| ``config/packages/*.yaml``, so you must only configure the differences with | ||
| those files; |
There was a problem hiding this comment.
Maybe add a tip that, if the configuration is equal to some other env, using symlinks is a great idea? I.e. in our staging environment, almost everything is production settings, except from framework.debug and monolog. So all other config/packages/prod/*.yaml are symlinked to config/packages/staging/*.yaml
|
Wouter, thanks for your review. I think you were right about everything, so I made some fixes and improvements. |
ba206a2 to
27bd3bb
Compare
javiereguiluz
added a commit
that referenced
this pull request
Jun 12, 2019
This PR was squashed before being merged into the 4.2 branch (closes #11690). Discussion ---------- Revamped the main configuration file The main configuration file is a mess and looks outdated. This PR revamps everything and merges the main 4 config files into a single reference file. This unique file explains 80% of what you need to know about config: * The config/ structure * The config/packages/ files * Config formats * Config parameters * Config Environments * Env Vars * The multiple .env files Commits ------- 27bd3bb Revamped the main configuration file
This was referenced Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main configuration file is a mess and looks outdated. This PR revamps everything and merges the main 4 config files into a single reference file. This unique file explains 80% of what you need to know about config: