[OptionsResolver] Add note about deprecated options #11704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the use case for this note: $resolver->setDefaults([
'foo' => null,
'bar' => function (Options $options) {
// needed to keep BC,
// and do not use $options['foo'] here, it'll trigger the deprecation
return $options->offsetGet('foo', false); // does not trigger the deprecation
},
]);
$resolver->setDeprecated('foo', 'The "foo" option is deprecated, use "bar" instead.'); |
OskarStark
reviewed
Jun 9, 2019
OskarStark
approved these changes
Jun 9, 2019
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2019
…ruto) This PR was squashed before being merged into the 4.2 branch (closes #11704). Discussion ---------- [OptionsResolver] Add note about deprecated options Missing piece related to symfony/symfony#28878 Commits ------- aaac426 [OptionsResolver] Add note about deprecated options
|
Thanks Yonel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing piece related to symfony/symfony#28878