Skip to content

Don't mention the Symfony Standard edition in the contributing docs #11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Don't mention the Symfony Standard edition in the contributing docs #11712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions contributing/community/reviews.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ The steps for the review are:

#. **Is the Report Complete?**

Good bug reports contain a link to a fork of the `Symfony Standard Edition`_
(the "reproduction project") that reproduces the bug. If it doesn't, the
report should at least contain enough information and code samples to
reproduce the bug.
Good bug reports contain a link to a project (the "reproduction project")
created with the `Symfony skeleton`_ or the `Symfony website skeleton`_
that reproduces the bug. If it doesn't, the report should at least contain
enough information and code samples to reproduce the bug.

#. **Reproduce the Bug**

Download the reproduction project and test whether the bug can be reproduced
on your system. If the reporter did not provide a reproduction project,
create one by forking_ the `Symfony Standard Edition`_.
create one based on one `Symfony skeleton`_ (or the `Symfony website skeleton`_).

#. **Update the Issue Status**

Expand Down Expand Up @@ -96,7 +96,7 @@ The steps for the review are:

Thank you @weaverryan for creating this bug report! This indeed looks
like a bug. I reproduced the bug in the "kernel-bug" branch of
https://github.com/webmozart/symfony-standard.
https://github.com/webmozart/some-project.

Status: Reviewed

Expand Down Expand Up @@ -134,9 +134,9 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:
#. **Reproduce the Problem**

Read the issue that the pull request is supposed to fix. Reproduce the
problem on a clean `Symfony Standard Edition`_ project and try to understand
why it exists. If the linked issue already contains such a project, install
it and run it on your system.
problem on a new project created with the `Symfony skeleton`_ (or the
`Symfony website skeleton`_) and try to understand why it exists. If the
linked issue already contains such a project, install it and run it on your system.

#. **Review the Code**

Expand Down Expand Up @@ -211,7 +211,8 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:

.. _GitHub: https://github.com
.. _Symfony issue tracker: https://github.com/symfony/symfony/issues
.. _Symfony Standard Edition: https://github.com/symfony/symfony-standard
.. _`Symfony skeleton`: https://github.com/symfony/skeleton
.. _`Symfony website skeleton`: https://github.com/symfony/website-skeleton
.. _create a GitHub account: https://help.github.com/articles/signing-up-for-a-new-github-account/
.. _forking: https://help.github.com/articles/fork-a-repo/
.. _bug reports in need of review: https://github.com/symfony/symfony/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22Bug%22+label%3A%22Status%3A+Needs+Review%22+
Expand Down