-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Document the new property path options of the Range constraint #11793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javiereguiluz
merged 1 commit into
symfony:4.4
from
Lctrs:validator/range-property-paths
Jul 10, 2019
Merged
Document the new property path options of the Range constraint #11793
javiereguiluz
merged 1 commit into
symfony:4.4
from
Lctrs:validator/range-property-paths
Jul 10, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 20, 2019
Please target 4.4 brach instead of master |
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Jul 8, 2019
…in range constraint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes #31511). Discussion ---------- [Validator] Allow to use property paths to get limits in range constraint | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Part of #31503 | License | MIT | Doc PR | symfony/symfony-docs#11793 Similar as #22576, but for the `Range` constraint. Commits ------- 2b509904c8 [Validator] Allow to use property paths to get limits in range constraint
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 8, 2019
…in range constraint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes #31511). Discussion ---------- [Validator] Allow to use property paths to get limits in range constraint | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Part of #31503 | License | MIT | Doc PR | symfony/symfony-docs#11793 Similar as #22576, but for the `Range` constraint. Commits ------- 2b50990 [Validator] Allow to use property paths to get limits in range constraint
@OskarStark Ref. PR has been merged. :) |
@Lctrs what a nice contribution! And you even included the "versionadded" directives too, so I can only say ... thanks a lot! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 10, 2019
…traint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes #11793). Discussion ---------- Document the new property path options of the Range constraint Related PR : symfony/symfony#31511 Commits ------- 08e724c Document the new property path options of the Range constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR : symfony/symfony#31511