Skip to content

Document the new property path options of the Range constraint #11793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Document the new property path options of the Range constraint #11793

merged 1 commit into from
Jul 10, 2019

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Jun 19, 2019

Related PR : symfony/symfony#31511

@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Jun 20, 2019
@OskarStark OskarStark added this to the 4.4 milestone Jun 20, 2019
@OskarStark
Copy link
Contributor

Please target 4.4 brach instead of master

@Lctrs Lctrs changed the base branch from master to 4.4 June 20, 2019 09:08
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Jul 8, 2019
…in range constraint (Lctrs)

This PR was squashed before being merged into the 4.4 branch (closes #31511).

Discussion
----------

[Validator] Allow to use property paths to get limits in range constraint

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | Part of #31503
| License       | MIT
| Doc PR        | symfony/symfony-docs#11793

Similar as #22576, but for the `Range` constraint.

Commits
-------

2b509904c8 [Validator] Allow to use property paths to get limits in range constraint
fabpot added a commit to symfony/symfony that referenced this pull request Jul 8, 2019
…in range constraint (Lctrs)

This PR was squashed before being merged into the 4.4 branch (closes #31511).

Discussion
----------

[Validator] Allow to use property paths to get limits in range constraint

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | Part of #31503
| License       | MIT
| Doc PR        | symfony/symfony-docs#11793

Similar as #22576, but for the `Range` constraint.

Commits
-------

2b50990 [Validator] Allow to use property paths to get limits in range constraint
@Lctrs
Copy link
Contributor Author

Lctrs commented Jul 8, 2019

@OskarStark Ref. PR has been merged. :)

@javiereguiluz
Copy link
Member

@Lctrs what a nice contribution! And you even included the "versionadded" directives too, so I can only say ... thanks a lot!

@javiereguiluz javiereguiluz merged commit 08e724c into symfony:4.4 Jul 10, 2019
javiereguiluz added a commit that referenced this pull request Jul 10, 2019
…traint (Lctrs)

This PR was squashed before being merged into the 4.4 branch (closes #11793).

Discussion
----------

Document the new property path options of the Range constraint

Related PR : symfony/symfony#31511

Commits
-------

08e724c Document the new property path options of the Range constraint
@Lctrs Lctrs deleted the validator/range-property-paths branch July 10, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants