[Process] allow writing "prepared" command line. #11802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jun 21, 2019
fabpot
reviewed
Jun 26, 2019
| @@ -350,6 +350,19 @@ instead:: | |||
| ); | |||
| $process->run(); | |||
|
|
|||
| Using a Prepared Command Line | |||
| -------------------------------- | |||
There was a problem hiding this comment.
should the same length as the title itself to be valid
fabpot
requested changes
Jun 26, 2019
| Using a Prepared Command Line | ||
| -------------------------------- | ||
|
|
||
| This component also provides a way to use the process command with prepared using the double brackets notations: |
There was a problem hiding this comment.
missing word after with prepared
| -------------------------------- | ||
|
|
||
| This component also provides a way to use the process command with prepared using the double brackets notations: | ||
| Which means that you can use placeholder in order to have a process that can be changed only with the values and without changing the php code. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 26, 2019
…nes (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Process] Allow writing portable "prepared" command lines | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #23778 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#11802 <!-- required for new features --> Hey here, it's me, again ! I've talked with @nicolas-grekas and he gave me a new way of writing this feature that will not be a problem for people using things like {{ toto }} since we are using the linux style of using envvar, the replaced arguments is only replaced when using windows. This should not break anything and work as expected! see #24763 This makes `"$FOO"` work seamlessly on Linux and on Windows to reference an env var (that can be provided when calling e.g. the "run" method) Commits ------- 3f8354f [Process] Allow writing portable "prepared" command lines
|
@Simperfit do you find some time to finish this PR? 😃 Note for the mergers, this must go in |
|
Ill do it asap ;) |
|
Thanks for your work on this new feature! Cheers 😃 |
OskarStark
added a commit
to OskarStark/symfony-docs
that referenced
this pull request
Aug 15, 2019
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
* 4.4: Tweaks #11802 [Process] allow writing "prepared" command line.
|
Thanks @OskarStark |
xabbuh
reviewed
Aug 26, 2019
| Using a Prepared Command Line | ||
| -------------------------------- | ||
|
|
||
| This component also provides a way to use the process command with prepared using the double brackets notations: |
There was a problem hiding this comment.
What does "double bracket notation" mean?
nicolas-grekas
added a commit
to nicolas-grekas/symfony-docs
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the re-pushed prepared command line with a new style of writing it that does not break anything.
symfony/symfony#32126