[Cache] Make sure the chain cache configuration works #11813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the PR. I tested the new config and it works perfectly. |
nicolas-grekas
approved these changes
Jun 24, 2019
|
@Nyholm can you please confirm that this must go to 4.3 branch and not to 3.4 or 4.2? Thanks. |
|
Sorry, no. This is equally true for 3.4. All active versions of the docs should be updated with this PR. |
|
Thanks Tobias. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 25, 2019
…yholm) This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes #11813). Discussion ---------- [Cache] Make sure the chain cache configuration works I just tried the configuration and noticed a few issues. ~~Im not 100% sure this actually works.~~ Lets wait for symfony/symfony#32139 Im sure now Commits ------- 9fbebaf [Cache] Make sure the chain cache configuration works
|
Thank you for the review and thank you for merging |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 5, 2019
…y providing several adapters (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Allow creating chained cache pools by providing several adapters | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Replaces #30984, follows symfony/symfony-docs#11813 This PR allows defining several adapters for one pool. When doing so, this defines a chain pool. The benefit is that all chained pools get automatic namespace and lifetime, so things are transparent: ```yaml pools: my_chained_pool: default_lifetime: 12 adapters: - cache.adapter.array - cache.adapter.filesystem - {name: cache.adapter.redis, provider: 'redis://foo'} ``` (see fixtures for example of PHP/XML config) /cc @Nyholm @pborreli FYI Commits ------- 29ba091 [FrameworkBundle] Allow creating chained cache pools by providing several adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried the configuration and noticed a few issues.
Im not 100% sure this actually works.Lets wait for symfony/symfony#32139Im sure now