[Messenger] doc bloc moved #11827
Closed
[Messenger] doc bloc moved #11827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jun 28, 2019
|
Status: needs work |
|
@@weaverryan friendly ping, can you check #11827 (comment)? thx edit: Rewording done, need re review |
48d6568 to
55be0a1
Compare
|
@noniagriconomie thanks for this contribution! I tried to merge it, but our private merging tool showed some conflicts ... and sent some change to your pull request (that's why you see all those modified files ... which were sent accidentally by me via this merging tool). I created #12260 to replace this and I tried to cherry-pick your commit, but I saw the same conflict messages, so at the end I recreated the changes myself. I'm sorry! |
|
@javiereguiluz understood 👍 |
javiereguiluz
added a commit
that referenced
this pull request
Sep 2, 2019
…iluz) This PR was squashed before being merged into the 4.3 branch (closes #12260). Discussion ---------- Move some doc contents in a Messenger article This continues #11827. All credit goes to @noniagriconomie. Commits ------- 9707b69 Move some doc contents in a Messenger article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think moving a bit this bloc about
HandleTraitis better for readabilityFeel free to close the PR if not :)