-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Document how to create cache pool with framework config #11855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thanks :)
I updated and rebased this PR. It is ready for a final review. |
nicolas-grekas
approved these changes
Jul 10, 2019
xabbuh
approved these changes
Jul 19, 2019
OskarStark
approved these changes
Jul 19, 2019
It'd be great to merge this PR (branch 4.4) :) |
Expect it tomorrow 😊 |
Thank you Tobias. |
OskarStark
added a commit
that referenced
this pull request
Jul 30, 2019
…(Nyholm) This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead (closes #11855). Discussion ---------- Document how to create cache pool with framework config This is some docs for symfony/symfony#32294 I removed the "old" way of doing it because this is far better. Commits ------- b0dc28f Document how to create cache pool with framework config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some docs for symfony/symfony#32294
I removed the "old" way of doing it because this is far better.