Add stream_max_entries to full redis messenger dsn example #11878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI Alexander 👋 I don't really get your introduction for this PR. You wrote:
But isn't this the same line where this option needs to be added? Also can you please rebase your PR and use |
71ae81b to
467d6c2
Compare
|
@OskarStark rebased. |
OskarStark
approved these changes
Aug 19, 2019
|
Thank you Alexander. |
OskarStark
added a commit
that referenced
this pull request
Aug 19, 2019
…le (alexander-schranz) This PR was merged into the 4.4 branch. Discussion ---------- Add stream_max_entries to full redis messenger dsn example As introduced in: #11870 Should also added to the full dsn example which was added in: #11874 Commits ------- 467d6c2 Add stream_max_entries to full redis messenger dsn example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As introduced in: #11870
Should also added to the full dsn example which was added in: #11874