When overriding session service definition, make it public
#11993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::addFlash()` relies on getting the `session` service from the service container. Since 3.4 services defined in `services.yaml` are private by default. When overriding the `session` service definition, it has to be explicitly marked as public.
OskarStark
approved these changes
Jul 19, 2019
|
Thanks Peter! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 22, 2019
…blic (pbowyer) This PR was merged into the 4.2 branch. Discussion ---------- When overriding `session` service definition, make it public `Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::addFlash()` relies on getting the `session` service from the service container. Since 3.4 services defined in `services.yaml` are private by default. When overriding the `session` service definition, it has to be explicitly marked as public. The 4.2 documentation branch was the earliest I found containing this example service definition. Commits ------- 315103f When overriding `session` service definition, make it public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::addFlash()relies on getting thesessionservice from the service container.Since 3.4 services defined in
services.yamlare private by default. When overriding thesessionservice definition, it has to be explicitly marked as public.The 4.2 documentation branch was the earliest I found containing this example service definition.