Skip to content

Conversation

ogizanagi
Copy link
Contributor

Problem is this section title is hidden on https://symfony.com/doc/current/messenger/handler_results.html (as every other .section h1)

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jul 26, 2019
@javiereguiluz javiereguiluz merged commit 86ce39f into symfony:4.2 Jul 26, 2019
javiereguiluz added a commit that referenced this pull request Jul 26, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

[Messenger] Fix hidden section title

Problem is this section title is hidden on https://symfony.com/doc/current/messenger/handler_results.html (as every other `.section h1`)

Commits
-------

86ce39f [Messenger] Fix hidden section title
@javiereguiluz
Copy link
Member

Thanks Maxime! However, the real problem was that the first-level heading used --- instead of ===. In RST, the heading underscores are not predefined, but whatever you choose for the first-level headings is always considered first-level, the underscore selected for second-level headings is always for second-level, etc.

So, we've fixed differently in f31bc5b. Cheers!

@ogizanagi ogizanagi deleted the patch-3 branch July 26, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants