[Ldap] Documented the deprecation related to query_string #12050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 29, 2019
|
@Simperfit can you help? |
|
We'd love to have a quick review for this from security/LDAP experts. Maybe @lyrixx? Thanks! |
c6b84e6 to
382c5c8
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 26, 2019
…g (javiereguiluz) This PR was squashed before being merged into the 4.4 branch (closes #12050). Discussion ---------- [Ldap] Documented the deprecation related to query_string I need help to come up with a good value for the `search_dn` option in this example. Also, should we mention this in the other place where we talk about `query_string`? Here: https://symfony.com/doc/current/reference/configuration/security.html#query-string Thanks. Commits ------- 382c5c8 [Ldap] Documented the deprecation related to query_string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need help to come up with a good value for the
search_dnoption in this example.Also, should we mention this in the other place where we talk about
query_string? Here: https://symfony.com/doc/current/reference/configuration/security.html#query-stringThanks.