[Yaml] Dump null as tilde #12071
Merged
[Yaml] Dump null as tilde #12071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
symfony-splitter
pushed a commit
to symfony/yaml
that referenced
this pull request
Aug 4, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] Add flag to dump NULL as ~ | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#12071 This PR adds the ability to dump `null` as `~` by a new Flag `Yaml::DUMP_NULL_AS_TILDE`: ```diff - foo: null + foo: ~ ``` Todos: - [x] Fix/add tests Commits ------- 749c11d94c [Yaml] Add flag to dump NULL as ~
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 4, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] Add flag to dump NULL as ~ | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#12071 This PR adds the ability to dump `null` as `~` by a new Flag `Yaml::DUMP_NULL_AS_TILDE`: ```diff - foo: null + foo: ~ ``` Todos: - [x] Fix/add tests Commits ------- 749c11d [Yaml] Add flag to dump NULL as ~
|
The code is merged, please review @xabbuh, thanks 😃 |
xabbuh
requested changes
Aug 5, 2019
maxhelias
approved these changes
Aug 5, 2019
1f74071 to
68cf0cf
Compare
xabbuh
approved these changes
Aug 5, 2019
OskarStark
added a commit
that referenced
this pull request
Aug 5, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] Dump null as tilde Docs for symfony/symfony#32669 Commits ------- 68cf0cf [Yaml] Dump null as tilde
OskarStark
added a commit
that referenced
this pull request
Aug 6, 2019
…iereguiluz) This PR was squashed before being merged into the 4.4 branch (closes #12090). Discussion ---------- [Yaml] Tweaked the DUMP_NULL_AS_TILDE explanation I couldn't add my review to #12071 on time, so that's why I create this PR. It's OK to close this without merging if you disagree with it. Thanks. Commits ------- ea71f5a [Yaml] Tweaked the DUMP_NULL_AS_TILDE explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#32669