@nicolas-grekas I would appreciate a review from your side here. Thanks

I finally merged this ... after making all changes requested by Oskar and Nicolas. Thanks for the reviews!

@jderusse thanks a lot for contributing these docs. I have two quick questions about things I wasn't entirely sure:

• The three features (method polyfills, namespaced aliases, void removal) were introduced in Symfony 4.4? (I added versionadded:: 4.4 to all of them, but I want to be sure).
• I don't understand the class MyTest extends TestCase example in the section Removing the Void Return Type:
  • Why do we have two doSetup() methods? You can use both at the same time or do you have to choose one?
  • I don't understand this comment: "visibility and return type-hint of method is free" What does "is free" mean?

Thanks!

Soory @javiereguiluz I was in holiday and missed the comment on that PR..

The three features [...] were introduced in Symfony 4.4?

yes

Why do we have two doSetup

it was to show that we are free to override method doSetup with or without return type. Maybe I should have write:

But it's confusing, we can remove this.

    class MyTest extends TestCase
    {
        use SetUpTearDownTrait;
        private $state;

        private function doSetup()
        {
            $this->state = 'demo';
        }
    }

    class MyTest extends TestCase
    {
        use SetUpTearDownTrait;
        private $state;

-       private function doSetup()
+       private function doSetup(): void // you can set a return type
        {
            $this->state = 'demo';
        }
    }

    class MyTest extends TestCase
    {
        use SetUpTearDownTrait;
        private $state;

-       private function doSetup()
+       protected function doSetup() // you can set a different visibility
        {
            $this->state = 'demo';
        }
    }