Add documentation about alpha3 methods #12105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2019
symfony-splitter
pushed a commit
to symfony/intl
that referenced
this pull request
Aug 9, 2019
…braten-certua) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Support ISO 3166-1 Alpha-3 country codes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20313 | Doc PR | symfony/symfony-docs#12105 | License | MIT This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component. Commits ------- 848f60e905 Support ISO 3166-1 Alpha-3 country codes
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 9, 2019
…braten-certua) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Support ISO 3166-1 Alpha-3 country codes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20313 | Doc PR | symfony/symfony-docs#12105 | License | MIT This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component. Commits ------- 848f60e Support ISO 3166-1 Alpha-3 country codes
|
@ro0NL would you do me a favor and review this PR? Thank you 😃 |
ro0NL
approved these changes
Aug 14, 2019
ro0NL
reviewed
Aug 14, 2019
| @@ -79,6 +79,20 @@ The ``Languages`` class provides access to the name of all languages:: | |||
| $language = Languages::getName('fr'); | |||
| // => 'French' | |||
|
|
|||
| If you want to you can also use the ISO 639-2 three-letter language codes instead of | |||
| the ISO 639-1 two-letter codes. (They are here called alpha3 codes.) | |||
There was a problem hiding this comment.
You can also use the ISO 639-2 three-letter language codes instead of
the ISO 639-1 two-letter codes, respectively called alpha3 and alpha2 codes.
|
|
||
| use Symfony\Component\Intl\Countries; | ||
|
|
||
| \Locale::setDefault('en'); | ||
|
|
||
| // Indexed with alpha-2 | ||
| $countries = Countries::getNames(); | ||
| // ('countryCode' => 'countryName') |
There was a problem hiding this comment.
perhaps mention "alpha2" here to reduce comments, e.g. // ('alpha2Code' => 'countryName')
| $countries = Countries::getNames(); | ||
| // ('countryCode' => 'countryName') | ||
| // => ['AF' => 'Afghanistan', 'AX' => 'Åland Islands', ...] | ||
|
|
||
| // Indexed with alhpa-3 | ||
| $countries = Countries::getAlpha3Names(); | ||
| // ('countryCode' => 'countryName') |
There was a problem hiding this comment.
same // ('alpha3Code' => 'countryName')
| $country = Countries::getName('GB', 'de'); | ||
| // => 'Vereinigtes Königreich' | ||
|
|
||
| $country = Countries::getName('GBR', 'de'); |
| $isValidCountry = Countries::exists($countryCode); | ||
| $isValidCountry = Countries::exists($alpha2Code); | ||
|
|
||
| $isValidCountry = Countries::alpha3CodeExists($alpha2Code); |
There was a problem hiding this comment.
i would add a paragraph in between like languages does
Or if you have a alpha3 country code you want to check:
$isValidCountry = Countries::alpha3CodeExists($alpha3Code);
| @@ -94,6 +108,16 @@ to catching the exception, you can also check if a given language code is valid: | |||
|
|
|||
| $isValidLanguage = Languages::exists($languageCode); | |||
|
|
|||
| Or if you have a three-letter language code you want to check: | |||
There was a problem hiding this comment.
:: i believe (not a format expert here :D)
|
It took time, but here we go, this is in now. Thank you very much Terje. I made the requested changes while merging (b3d776d) 👍 |
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
* 4.4: Tweaks. refs #12105 Add documentation about alpha3 methods
Merged
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Update intl.rst tiny follow up of #12105 cc @OskarStark Commits ------- d757a2d Update intl.rst
OskarStark
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was squashed before being merged into the 4.3 branch (closes #12173). Discussion ---------- Mention ISO 639 for languages we've added this in 4.4 (#12105), but languages in 4.3 already had (partial) alpha3 support. let me know if this is merged in 4.4 :) it needs some cleanup after. cc @OskarStark Commits ------- 8ee8df7 Mention ISO 639 for languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #12104