[FrameworkBundle][DX] Improving redirect config when using RedirectController #12189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Aug 17, 2019
yceruto
added a commit
to symfony/symfony
that referenced
this pull request
Aug 23, 2019
…en using RedirectController (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][DX] Improving the redirect config when using RedirectController | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#12189 follow-up #24637 **Before:** ```yaml # config/routes.yaml doc_shortcut: path: /doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction defaults: route: 'doc_page' legacy_doc: path: /legacy/doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::urlRedirectAction defaults: path: 'https://legacy.example.com/doc' ``` **After:** ```yaml # config/routes.yaml doc_shortcut: path: /doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController defaults: route: 'doc_page' legacy_doc: path: /legacy/doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController defaults: path: 'https://legacy.example.com/doc' ``` See more before/after configs (XML, PHP) in doc PR symfony/symfony-docs#12189 Commits ------- 0ebb469 Improving redirect config when using RedirectController
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Aug 23, 2019
…en using RedirectController (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][DX] Improving the redirect config when using RedirectController | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#12189 follow-up symfony/symfony#24637 **Before:** ```yaml # config/routes.yaml doc_shortcut: path: /doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction defaults: route: 'doc_page' legacy_doc: path: /legacy/doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::urlRedirectAction defaults: path: 'https://legacy.example.com/doc' ``` **After:** ```yaml # config/routes.yaml doc_shortcut: path: /doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController defaults: route: 'doc_page' legacy_doc: path: /legacy/doc controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController defaults: path: 'https://legacy.example.com/doc' ``` See more before/after configs (XML, PHP) in doc PR symfony/symfony-docs#12189 Commits ------- 0ebb469 Improving redirect config when using RedirectController
|
Code merged! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 2, 2019
…ng RedirectController (yceruto) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle][DX] Improving redirect config when using RedirectController Update according to symfony/symfony#33217 Commits ------- f59c61f [DX] Improving redirect config
|
Yonel, thanks for this nice feature and for providing the docs too. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update according to symfony/symfony#33217