Skip to content

Update workflow configuration example following Symfony 4.3 deprecations #12270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

benjamintoussaint
Copy link
Contributor

Added 'initial_marking' and added 'marking_store' with 'type: method' and property name.

Added 'initial_marking' and added 'marking_store' with 'type: method' and property name.
@javiereguiluz
Copy link
Member

@benjamintoussaint thanks for contributing these fixes.
@lyrixx could you please review these proposed changes? Thanks!

@javiereguiluz javiereguiluz added this to the 4.3 milestone Sep 11, 2019
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is perfect.
Thanks!

@javiereguiluz
Copy link
Member

javiereguiluz commented Sep 11, 2019

This is now merged! Benjamin, thanks and congrats on your first Symfony Docs contribution.

javiereguiluz added a commit that referenced this pull request Sep 11, 2019
…4.3 deprecations (benjamintoussaint)

This PR was merged into the 4.3 branch.

Discussion
----------

Update workflow configuration example following Symfony 4.3 deprecations

Added 'initial_marking' and added 'marking_store' with 'type: method' and property name.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

f604a61 Update workflow configuration example following Symfony 4.3 deprecations
@javiereguiluz javiereguiluz merged commit f604a61 into symfony:4.3 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants