-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Reworded all the docs related to templates and Twig #12274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review! I love getting a fresh look at these docs :)
yceruto
reviewed
Sep 5, 2019
Could you please fix the issues spotted by the doc ? 😁 |
f087d3e
to
ec618e1
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 11, 2019
…iereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #12274). Discussion ---------- Reworded all the docs related to templates and Twig As we did in the past with other topics, this pull request revamps the templating/templates/twig docs. The main goals were: * Create a single article `/templates.rst` that explain everything about templates. * Keep some `templating/*.rst` articles for uncommon things (PHP, Twig extensions, hinclude, etc.) * Remove all the small `templating/*.rst` articles. * Simplify all explanations and reduce verbosity. * Add more cross-links between articles. ----- The TOC of the new article looks like this: ``` Twig Templating Language Twig Configuration Creating Templates Template Naming Template Location Template Variables Linking to Other Pages Linking to CSS and JavaScript Assets The App Global Variable Rendering Templates Rendering Templates in Routes Rendering Templates in Controllers Rendering Templates in Services Rendering Templates in Emails Checking if a Template Exists Debugging Templates Linting Twig Templates Inspecting Twig Information The Dump Twig Utilities Reusing Template Contents Including Templates Embedding Controllers Template Inheritance and Layouts Output Escaping Template Namespaces Learn More ``` Commits ------- ec618e1 Reworded all the docs related to templates and Twig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we did in the past with other topics, this pull request revamps the templating/templates/twig docs. The main goals were:
/templates.rst
that explain everything about templates.templating/*.rst
articles for uncommon things (PHP, Twig extensions, hinclude, etc.)templating/*.rst
articles.The TOC of the new article looks like this: