Removing the tests for PHP 7.0 #12277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kynno good catch! Thanks for improving this. About the PHPUnit, yes you are right. I'm not sure which is the official Symfony recommendation to avoid this issue. Maybe @nicolas-grekas can help us here. Thanks! |
|
the build issue has been fixed weeks ago, but you need a recent enough phpunit bridge of course |
|
You're right. So what I did to fix this issue with PHPUnit is:
<php>
<env name="SYMFONY_PHPUNIT_VERSION" value="7.5" />
</php>I'm not sure we need to mention this as in this case it was related to my own settings in my |
|
@Kynno thanks for improving this. We've merged so the pull request doesn't get stalled ... but we can do further improvements to this file in future pull requests. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 10, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Removing the tests for PHP 7.0 As Symfony 4 requires minimum PHP 7.1, some builds testing PHP 7.0 will automatically fail. Also, I want to mention that the builds line 199 and 201 are not running because of the following error: ``` PHP Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.3.zip): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found ``` If I remember well, some months ago PHPUnit removed all old available version and I guess that's what's causing the error Commits ------- d85f6c4 Removing the tests for PHP 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Symfony 4 requires minimum PHP 7.1, some builds testing PHP 7.0 will automatically fail.
Also, I want to mention that the builds line 199 and 201 are not running because of the following error:
If I remember well, some months ago PHPUnit removed all old available version and I guess that's what's causing the error