[Form] Added the attr_row option to all form types #12302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Sep 11, 2019
a9bbcbb to
4c929e7
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 12, 2019
…ereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #12302). Discussion ---------- [Form] Added the attr_row option to all form types Fixes #11560. I also added the `attr` inherited option in the types which were missing it. Commits ------- 4c929e7 [Form] Added the attr_row option to all form types
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11560.
I also added the
attrinherited option in the types which were missing it.