Skip to content

[Validator] Options min and max of Length constraint not required simultaneously #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ohvitorino
Copy link

As for the Count validator constraint (see: #12416]) the options min and max of the Length constraint are not required simultaneously.

@xabbuh
Copy link
Member

xabbuh commented Oct 7, 2019

This applies to the 3.4 branch too, doesn't it?

@ohvitorino ohvitorino changed the base branch from master to 3.4 October 7, 2019 13:07
@ohvitorino ohvitorino changed the base branch from 3.4 to master October 7, 2019 13:07
@ohvitorino
Copy link
Author

@xabbuh I'll rebase it

@xabbuh xabbuh added this to the 3.4 milestone Oct 7, 2019
@ohvitorino ohvitorino force-pushed the length-parameters-are-not-required-at-the-same-time branch from e07d7e7 to 0f22305 Compare October 7, 2019 13:24
@ohvitorino ohvitorino changed the base branch from master to 3.4 October 7, 2019 13:25
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thank you.

javiereguiluz added a commit that referenced this pull request Oct 8, 2019
… not required simultaneously (ohvitorino)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Options `min` and `max` of Length constraint not required simultaneously

As for the Count validator constraint (see: #12416]) the options `min` and `max` of the Length constraint are not required simultaneously.

Commits
-------

0f22305 Make clear when the options min and max are required
@javiereguiluz javiereguiluz merged commit 0f22305 into symfony:3.4 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants