Skip to content

[Security] Added article on password migrations #12467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

[Security] Added article on password migrations #12467

merged 1 commit into from
Dec 2, 2019

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 12, 2019 •
edited
Loading

Fixes #12395, #12612

Please note that I did not yet test the code examples in this article.

#SymfonyHackathon

@wouterj wouterj force-pushed the issue-12395/password-rehash branch 3 times, most recently from deb4ef6 to 2f4e7c4 Compare October 13, 2019 00:03
@chalasr
Copy link
Member

chalasr commented Oct 27, 2019 •
edited
Loading

I suggest to wait for symfony/symfony#34020 before finishing this one :)

@wouterj
Copy link
Member Author

wouterj commented Oct 29, 2019 •
edited
Loading

For the reference, I'm waiting on symfony/symfony#34139 as well before finishing this article. I think we should then have the complete picture (and it's a nice picture!)

@chalasr
Copy link
Member

chalasr commented Nov 9, 2019

Unlocked now that symfony/symfony#34139 has been merged

@chalasr
Copy link
Member

chalasr commented Nov 9, 2019

Should also fix #12612

@wouterj wouterj removed the On hold label Nov 9, 2019
@OskarStark OskarStark added this to the 4.4 milestone Nov 11, 2019
@wouterj wouterj force-pushed the issue-12395/password-rehash branch 3 times, most recently from 079ec85 to cf201fa Compare November 23, 2019 09:48
@wouterj wouterj force-pushed the issue-12395/password-rehash branch from cf201fa to 0de1588 Compare December 1, 2019 14:00
@wouterj
Copy link
Member Author

wouterj commented Dec 1, 2019

Thanks @chalasr!

This PR is ready for a final review & merge imho

chalasr
chalasr approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

wouterj added a commit that referenced this pull request Dec 2, 2019
@wouterj
feature #12467 [Security] Added article on password migrations (wouterj)
09aee36 
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Added article on password migrations

Fixes #12395, #12612

Please note that I did not yet test the code examples in this article.

#SymfonyHackathon

Commits
-------

0de1588 Added article on password migrations
@wouterj wouterj merged commit 0de1588 into symfony:4.4 Dec 2, 2019
@wouterj wouterj deleted the issue-12395/password-rehash branch December 2, 2019 10:55
@chalasr chalasr mentioned this pull request Dec 3, 2019
Closed
@chalasr
Copy link
Member

chalasr commented Dec 3, 2019

@wouterj We forgot something! :) #12756

@chalasr chalasr mentioned this pull request Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@OskarStark OskarStark OskarStark left review comments

@chalasr chalasr chalasr approved these changes

Assignees

@wouterj wouterj

Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@wouterj @chalasr @javiereguiluz @OskarStark @carsonbot