Documentation for Size and SizeLength (Fixes #738) #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2012
Documentation for Size and SizeLength (Fixes #738)
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2012
|
Hi Ricard! Well done! These are covered very well and with a format that's consistent with the other entries. I proofread and made some tweaks, but it's very good! Thanks for your contribution! |
|
Hi Ryan! Thanks for accepting and fixing my pull request. I didn't notice that text should be split at about 70-80 characters. Also small typos :) Glad to collaborate and thanks for mantaining Symfony2 documentation. This is one of the things that really make a difference. I will have a look at other issues and see if I can provide some more documentation Best regards! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note I am not English native so typos (and actually better ways to say things) might exist.
In issue #738 Image fields are mentioned but documentation for Image constraint seems to be already fixed