Fixing description of default behaviour of testclient on redirects, see #1254 #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2012
Fixing description of default behaviour of testclient on redirects, see #1254
|
Hi Sebastian! Wow, good detective work (details in #1254)! You're right that the while the BrowserKit follows redirects by default, the sub-classes in HttpKernel (which is what's used by the framework) does not. I've merged this in - thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in issue #1254, the client does not follow redirects automatically. I changed the text to point out this behaviour and show a way to both follow one redirect at a time and to follow all redirects.