Skip to content

Add new WeekType Documentation #12584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Conversation

dFayet
Copy link

@dFayet dFayet commented Nov 3, 2019

Documents new symfony/symfony#32061 feature
Fix #12583

@dFayet dFayet requested a review from xabbuh as a code owner November 3, 2019 14:45
@dFayet dFayet force-pushed the feature/week_type branch 2 times, most recently from df6c5c2 to 7b8346a Compare November 3, 2019 15:08
wouterj added a commit that referenced this pull request Nov 9, 2019
This PR was merged into the 4.4 branch.

Discussion
----------

Add new WeekType Documentation

Documents new symfony/symfony#32061 feature
Fix #12583

Commits
-------

8cd2e65 Add WeekType Documentation
wouterj added a commit that referenced this pull request Nov 9, 2019
@wouterj wouterj merged commit 8cd2e65 into symfony:4.4 Nov 9, 2019
@wouterj
Copy link
Member

wouterj commented Nov 9, 2019

Thanks a lot for taking care of documenting your new feature! This is great documentation. I've now merged it and only did a few very very minor tweaks in 76076cf.

Hope to see you back in the future with more contributions!

wouterj added a commit that referenced this pull request Nov 9, 2019
* 4.4:
  [#12600] Added versionadded for invokable listeners
  Revert "bug #12600 [Doctrine] Don't mention invokable listeners in 4.3 (javiereguiluz)"
  [#12584] Small tweaks
  Add WeekType Documentation
  [Doctrine] Don't mention invokable listeners in 4.3
  [Messenger] update events for 4.4
  Use normalizer context constants everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants