Skip to content

remove 'command' from execute argument #12652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2019
Merged

remove 'command' from execute argument #12652

merged 1 commit into from
Nov 23, 2019

Conversation

aldenw
Copy link
Contributor

@aldenw aldenw commented Nov 20, 2019

Including the 'command' argument triggers an exception, "Symfony\Component\Console\Exception\InvalidArgumentException : The "command" argument does not exist.", needs to be removed.

Including the 'command' argument triggers an exception, "Symfony\Component\Console\Exception\InvalidArgumentException : The "command" argument does not exist.", needs to be removed.
@wouterj wouterj changed the base branch from 4.3 to 3.4 November 23, 2019 11:23
@wouterj
Copy link
Member

wouterj commented Nov 23, 2019

Hi! Thanks a lot for taking the time to submit a pull request!

Are you sure you're using the CommandTester#execute() method and not the Command#execute() method? The tester does need the command argument, whereas the command doesn't need it.

However, since a long time already, the tester adds this command argument automatically based on the command you pass:
https://github.com/symfony/console/blob/17b154f932c5874cdbda6d05796b6490eec9f9f7/Tester/CommandTester.php#L57-L62 So we can still merge your contribution 😃 (did that in 3.4 and I'll merge it up from there)

wouterj added a commit that referenced this pull request Nov 23, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #12652).

Discussion
----------

remove 'command' from execute argument

Including the 'command' argument triggers an exception, "Symfony\Component\Console\Exception\InvalidArgumentException : The "command" argument does not exist.", needs to be removed.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

9030c6b remove 'command' from execute argument
@wouterj wouterj merged commit 9030c6b into symfony:3.4 Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants