Skip to content

Update readme #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

Update readme #12658

merged 1 commit into from
Dec 9, 2019

Conversation

noniagriconomie
Copy link
Contributor

I think by means like if SymfonyCloud is a CI or something like that
no? (feel free to close)

@tucksaun
Copy link
Contributor

This was indeed not really clear.
The SymfonyCloud build kind-of serve as integration tests, I don't know if it would be more clear but maybe we should mention that is "built by" and made available available for preview **on **?

@noniagriconomie
Copy link
Contributor Author

it just feels weird when i read it, that is why i opened this to find an improvement :)

@wouterj
Copy link
Member

wouterj commented Nov 23, 2019

Let's ping our native @weaverryan here.

We use SymfonyCloud to build & serve a documentation for each pull request + the documentation is served on symfony.com, which runs on SymfonyCloud as well. So it's more "we use SymfonyCloud" than " we're build by SymfonyCloud" imho.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Nov 24, 2019
@javiereguiluz javiereguiluz changed the base branch from master to 3.4 December 9, 2019 15:36
javiereguiluz added a commit that referenced this pull request Dec 9, 2019
@javiereguiluz
minor #12658 Update readme (noniagriconomie)
5aff5b3 
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #12658).

Discussion
----------

Update readme

I think `by` means like if SymfonyCloud is a CI or something like that
no? (feel free to close)

Commits
-------

c009c1b Update readme
@javiereguiluz javiereguiluz merged commit c009c1b into symfony:3.4 Dec 9, 2019
@javiereguiluz
Copy link
Member

javiereguiluz commented Dec 9, 2019 •
edited
Loading

Thank you all for the discussion. To not keep this pull request open too long, we decided to merge it but tweak the message. It now reads as follows:

Thanks to [SymfonyCloud](https://symfony.com/cloud) for providing an integration
server where Pull Requests are built and can be reviewed by contributors.

@noniagriconomie noniagriconomie deleted the patch-3 branch December 9, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan Awaiting requested review from weaverryan

@tucksaun tucksaun Awaiting requested review from tucksaun

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@noniagriconomie @tucksaun @wouterj @javiereguiluz @carsonbot